Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tabs, set default to true for snapshot, link loader #914

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Restore tabs, set default to true for snapshot, link loader #914

merged 6 commits into from
Dec 27, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Dec 27, 2023 •
edited
Loading

  • Clicking on the mirror name links in the mirror tables in the mirror page sometimes has a small delay so this PR displays a loader there.
  • Sets default snapshot setting to true
  • Restores tab persistence on refresh functionality in specific mirror page

serprex
serprex requested changes Dec 27, 2023
View reviewed changes
ui/app/mirrors/create/helpers/cdc.ts Outdated Show resolved Hide resolved
@Amogh-Bharadwaj Amogh-Bharadwaj enabled auto-merge (squash) December 27, 2023 20:52
@Amogh-Bharadwaj Amogh-Bharadwaj merged commit c9e5e90 into main Dec 27, 2023
10 checks passed
@serprex serprex deleted the ui/improvements-7 branch July 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amogh-Bharadwaj @serprex